Deprecate std.enums.nameCast. #23524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently there is a tendency to remove stuff from std.meta. And std.enums.nameCast seems like a missed function since it's in a different namespace. Reasons: `@field(Enum, @TagName(tag))` ^ is just shorter to write compared to `std.meta.nameCast(Enum, tag)` nameCast's only advantage is that it can be used interchangeably with strings. But a search through common codebases (zig, bun, tigerbeetle, ...) only tigerbeetle uses it and only in non-generic way e.g. exclusively with strings or with tags. It's also pretty buggy and allows usage with bizarre parameters such as `std.meta.nameCast(type, Enum)`.
alexrp
reviewed
Apr 10, 2025
Co-authored-by: Alex Rønne Petersen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently there is a tendency to remove stuff from std.meta. And std.enums.nameCast seems like a missed function since it's in a different namespace.
More specific reasons:
@field(Enum, @tagName(tag))^ is just shorter to write compared to
std.meta.nameCast(Enum, tag)nameCast's only advantage is that it can be used interchangeably with strings. But a search through common codebases (zig, bun, tigerbeetle, ...) only tigerbeetle uses it 3 times and only in non-generic way e.g. exclusively with strings or with tags.
It's also pretty buggy and allows usage with bizarre parameters such as
std.meta.nameCast(type, Enum).