stage1: add @hasField() built-in #2438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was quite straight-forward Closes: ziglang#1439
|
It doesn't work on imports. |
|
shouldn't it be |
|
@emekoi your right. That is the correct documentation of what the code already does. |
Actually include the tests I wrote
andrewrk
requested changes
May 28, 2019
| IrInstruction base; | ||
|
|
||
| IrInstruction *container_type; | ||
| Buf *field_name_buffer; |
There was a problem hiding this comment.
I don't think the existence of this field is correct. I think you can follow this pattern: 269a53b
There was a problem hiding this comment.
I was following another existing pattern.
|
Thanks, and please have a look at the fixups commit: df11512 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was quite straight-forward
Closes: #1439