-
-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to new module system #1698
Conversation
forgot to update the min zig version of course lol |
|
oh thats funny, the changes to the expectEqual function meant to make them better to work with are actually causing CI to fail |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1698 +/- ##
==========================================
+ Coverage 76.12% 76.14% +0.01%
==========================================
Files 34 34
Lines 10007 10007
==========================================
+ Hits 7618 7620 +2
+ Misses 2389 2387 -2 ☔ View full report in Codecov by Sentry. |
Past experience tells me it might be a good idea to rename the current build runner and use it with zig versions < 2030, some/certain projects only update in large increments. |
Any projects that doesn't target the latest Zig shouldn't use the latest ZLS as well. |
Yeah, well #1396 |
e87f7d3
to
8a35990
Compare
8a35990
to
9f55463
Compare
realistically it doesnt matter since the 2 commits are like a day apart but updating the minimum version to the expectEqual change isnt required afaict. i tested earlier and the updated tests work with the new and old expectEqualDeep |
FYI, I have edited your PR and done the following:
|
The minimum build version had to be updated anyway because of ziglang/#18438, so I did it just in case. |
ah i actually did something a little sneaky before 😄 |
9f55463
to
c7d1b70
Compare
c7d1b70
to
9fbd994
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks to be in order finally.
The only thing missing are the nix flakes which I will update in a follow up PR once https://github.com/mitchellh/zig-overlay has updated again.
breaking changes from ziglang/zig#18160
made corresponding prs in known-folders and diffz, iiuc the hashes i used in the zon will still work once the prs are merged, github magic or whatever :p