wrap number hover in code block #2058
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xdBronch
force-pushed
the
push-purwylnonnur
branch
from
551556c
to
c2bfaf1
Compare
|
vscode assumes all comment text is markdown |
|
sorry but whats your point? does this make anything worse in vscode or just pointing out its not necessary there? i dont have it installed so i cant test. |
|
i was affirming that this not working in zed is a bug on their part |
|
zed-industries/zed#5386 upstream issue fwiw |
|
The downside of this change is that it prevents the table from being shown in "rendered" form if the editor supports Markdown tables (like VS Code). Before
After
I would suggest to use the clientInfo to check whether the client/editor is Zed and only in that case apply these changes. make sure to link the upstream issue in the code so that the workaround can be removed once its fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
without this zed would put everything on 1 line, arguably this is probably something they should fix but the
mdalso gives the numbers highlighting 🤷♂️. didnt notice this make anything worse on nvim or helix