Re-add -Dopenssl to zap build #63
Conversation
modify readme for instructions how to use it
| @@ -8,7 +8,7 @@ pub fn build(b: *std.build.Builder) !void { | |||
| const optimize = b.standardOptimizeOption(.{}); | |||
|
|
|||
| // Use an os env var to determine whether to build openssl support | |||
| const use_openssl = blk: { | |||
| const use_openssl = b.option(bool, "openssl", "Use system-installed openssl for TLS support in zap") orelse blk: { | |||
There was a problem hiding this comment.
That use of orelse is actually very clever!
README.md
Outdated
| @@ -273,6 +273,7 @@ Then, in your `build.zig`'s `build` function, add the following before | |||
| const zap = b.dependency("zap", .{ | |||
| .target = target, | |||
| .optimize = optimize, | |||
| //.openssl = true, // required to use tls | |||
There was a problem hiding this comment.
I am not entirely sure if it shouldn't read .openssl = false; // set to true for TLS ...?
There was a problem hiding this comment.
Yeah, that works. I'll switch that around.
|
Oh dang, you're pretty fast on that. Noticed I left the comment behind without reflecting the change. Get some sleep, my dude, this can wait 😅 |
|
Okokok. G'night 💤 |
honestly not sure how to concisely express that.
|
Okay, I'm done... I at least know how git amend works, now 🤔. Lemme know if you see any other docs that might need to be updated. |
|
I'll merge right after the CI checks have been completed, then add one more commit to the README, and replay the whole shebang on the zig-0.12.0 branch. Will let you know when ready.
|
Also includes a small modification to the readme for instructions how to pass it through from any project that depends on zap.
Would resolve #62 if accepted.
Lemme know what ya think.