Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simple router with handler clojures support #68

Merged
merged 3 commits into from
Jan 24, 2024

Conversation

StringNick
Copy link
Contributor

No description provided.

@renerocksai
Copy link
Member

Thanks, that's a great PR; I like the example. I hope I'll have more time later to look at it more closely before merging. I'd recommend naming it differently, more descriptively than hello3. Maybe something that communicates mapping routes to handler functions?

Also, please add it to the list of examples in the README, with a short description.

It's a really great example! Also, the self hack is genius! 👍

@renerocksai
Copy link
Member

oh, why not name it simple-router?

Copy link
Member

@renerocksai renerocksai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also document RequestHandler and Router.

src/router.zig Outdated Show resolved Hide resolved
src/router.zig Outdated Show resolved Hide resolved
src/router.zig Outdated Show resolved Hide resolved
src/zap.zig Outdated Show resolved Hide resolved
src/router.zig Outdated Show resolved Hide resolved
examples/hello3/hello3.zig Outdated Show resolved Hide resolved
@StringNick
Copy link
Contributor Author

thank you for review and comments, i will fix it, first version name was SimpleRouter, but i saw u refactored names and renamed too, will use SimpleRouter

Copy link
Member

@renerocksai renerocksai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking amazingly good!

@renerocksai renerocksai merged commit 9122d7f into zigzap:master Jan 24, 2024
2 checks passed
@renerocksai
Copy link
Member

Thx for the great work. Now, if you're up for it, could you please add doc comments for the zap.Router? Best take the zig-0.12.0 branch for that, as I fixed some const issues there (new zig is const-mad).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants