-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simple router with handler clojures support #68
Conversation
8de8b82
to
f13160e
Compare
Thanks, that's a great PR; I like the example. I hope I'll have more time later to look at it more closely before merging. I'd recommend naming it differently, more descriptively than hello3. Maybe something that communicates mapping routes to handler functions? Also, please add it to the list of examples in the README, with a short description. It's a really great example! Also, the |
oh, why not name it simple-router? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also document RequestHandler and Router.
thank you for review and comments, i will fix it, first version name was SimpleRouter, but i saw u refactored names and renamed too, will use SimpleRouter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking amazingly good!
Thx for the great work. Now, if you're up for it, could you please add doc comments for the zap.Router? Best take the zig-0.12.0 branch for that, as I fixed some const issues there (new zig is const-mad). |
No description provided.