TEST Golangci lint GitHub action integ #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es (aws#506) * Add linter config * Doc: Update deployment doc prefix lists Add IPv4 and IPv6 prefix list Ids to security group ingress onboarding step instead of the specific IP range used by the Lattice network. * Doc: Update development doc with prefix lists Add IPv4 and IPv6 prefix list Ids to security group ingress onboarding step instead of the specific IP range used by the Lattice network. * ci: Use mattn/goveralls instead of shogo821/goveralls * ci: Use mattn/goveralls instead of shogo821/goveralls * doc: update overview page for v1 * Doc: Update readme * doc: add link to SG docs in deploy * nit: space and wording cleanup
…ws#504) * - Removed deprecated annotation `application-networking.k8s.aws/lattice-vpc-association: "true"` - Improve the section "Set up single-cluster/VPC service-to-service communications" in getstarted.md * Address PR comments * address PR comments * Address PR comments --------- Co-authored-by: Zijun Wang <[email protected]>
* Fix target group leaking and e2etest * Fix grpcurl runner * Fix unit test * Fix more flaky/buggy e2e test cases * Rollback conditional * Address PR comments
Co-authored-by: Shawn Kaplan <[email protected]>
* - pass defaultServiceNetwork env variable - fix e2e test issue * pass defaultServiceNetwork env variable --------- Co-authored-by: Zijun Wang <[email protected]>
* Add linter config * Doc: Update deployment doc prefix lists Add IPv4 and IPv6 prefix list Ids to security group ingress onboarding step instead of the specific IP range used by the Lattice network. * Doc: Update development doc with prefix lists Add IPv4 and IPv6 prefix list Ids to security group ingress onboarding step instead of the specific IP range used by the Lattice network. * ci: Use mattn/goveralls instead of shogo821/goveralls * ci: Use mattn/goveralls instead of shogo821/goveralls * doc: update overview page for v1 * Doc: Update readme * doc: add link to SG docs in deploy * nit: space and wording cleanup * Docs: Major doc folder structure update * doc: add code of conduct * doc: Move api reference back to top-level nav * doc: fix merge conflict
…#514) Co-authored-by: Shawn Kaplan <[email protected]>
* Fix e2e tests and examples to be compatible w/ latest CRDs * Fix empty rule matching behavior
* Update Gateway resource docs and fix markdown styles
* add target group policy controller and status updates
* Docs: move envvar section and fix links
* Fix for leaking target groups on service delete due to listener delete race condition
* add log level env variable and update helm * update LOG_LEVEL env var in environment.md
* Release artifacts for v1.0.1 * Add deploy-v1.0.1.yaml
* bak * bak * bak * ci: Use mattn/goveralls instead of shogo821/goveralls # Conflicts: # hack/toolchain.sh * - Add new multi cluster doc, diagram and remove outdated ones - fix broken image link in the doc * Minor change * Address PR comments * Address PR comments * Address PR comments * Address PR comments * Address PR comments * Address PR comments --------- Co-authored-by: Zijun Wang <[email protected]>
* Improve presubmit workflow and add docs guide
…deploy.md in sync (aws#548) * make recommended-inline-policy.json content and the one shown in the deploy.md in sync * fix doc issue --------- Co-authored-by: Zijun Wang <[email protected]>
* - add more settings in k8s yaml to prevent privileges escalation - change image repo url from m7r9p7b3 to aws-application-networking-k8s * Minor change --------- Co-authored-by: Zijun Wang <[email protected]>
* Add service export/import documentations
…, VpcAssociationPolicy (aws#547)
* - First step to enable Golangci-lint - Change code base on Golangci-lint error message * Address PR comments * Address few PR comments --------- Co-authored-by: Zijun Wang <[email protected]>
- Change code base on Golangci-lint error message
Pull Request Test Coverage Report for Build 7054193842Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs from aws-gateway-controller showing the issue:
Testing done on this change:
Automation added to e2e:
Will this PR introduce any new dependencies?:
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.