sparse: add block-max wand and block-max maxscore algorithm #1026
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sparknack The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@sparknack 🔍 Important: PR Classification Needed! For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:
For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”. Thanks for your efforts and contribution to the community!. |
sparknack
force-pushed
the
sparse-new-algo
branch
from
c2f7b1a to
9e6f9bd
Compare
|
/hold |
| LOG_KNOWHERE_ERROR_ << "Failed to create mmap file when loading sparse InvertedIndex: " << strerror(errno); | ||
| return Status::disk_file_error; | ||
| } | ||
| temp_file.close(); |
There was a problem hiding this comment.
I'm not sure I follow why this is needed. Is the goal to set the file size to zero?
What does this function do exactly?
There was a problem hiding this comment.
Yes, just create a empty file which will be used for inverted index mmap.
| sort_cursors(); | ||
| } else { | ||
| size_t next_list = pivot; | ||
| for (; cursor_ptrs[next_list]->cur_vec_id_ == pivot_id; --next_list) { |
There was a problem hiding this comment.
is it needed to add a 'out-of-bound' safeguard here?
There was a problem hiding this comment.
no need.
next_list will not smaller than 0 since it is guaranteed that pivot_id == cursor_ptrs[0]->cur_vec_id_ is not true.
sparknack
force-pushed
the
sparse-new-algo
branch
from
9e6f9bd to
2c6ac02
Compare
Signed-off-by: Shawn Wang <[email protected]>
sparknack
force-pushed
the
sparse-new-algo
branch
from
2c6ac02 to
862f75a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1026 +/- ##
=========================================
+ Coverage 0 73.61% +73.61%
=========================================
Files 0 82 +82
Lines 0 7727 +7727
=========================================
+ Hits 0 5688 +5688
- Misses 0 2039 +2039 |
|
/lgtm overall |
No description provided.