Upgrade ActiveStar to 7.2 #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lvonk
force-pushed
the
upgrade_to_ar_7.2
branch
from
ef97b96 to
135fd94
Compare
erikrozendaal
approved these changes
Sep 10, 2024
lvonk
force-pushed
the
upgrade_to_ar_7.2
branch
from
135fd94 to
ff7b7b1
Compare
Two notable changes: - `establish_connection` defers actually making the connection until usage. So `active?` no longer returns true after calling `establish_connection`. - `quote_table_name` is no longer implemented in the module and should be called on the actual connection.
lvonk
force-pushed
the
upgrade_to_ar_7.2
branch
from
ff7b7b1 to
a67cfc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two notable changes:
establish_connectiondefers actually making the connection until usage. Soactive?no longer returns true after callingestablish_connection. See https://github.com/rails/rails/pull/49378/filesquote_table_nameis no longer implemented in the module and should be called on the actual connection.