-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
2399cf3
commit d014bc4
Showing
1 changed file
with
9 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
Feedback Change List on first version: | ||
|
||
- Added a bunch of comments to make props more desriptive and complex functions more selfexplanatory | ||
- Changed to the structure we discussed so know we have (const,interface,index,Stories,Component,types and data) instead of a piled file | ||
- JSON Conversion mainly for table components (Columns should be better of not be converted into JSON already discussed this with Stefanos) | ||
- SonarCloud code refactoring in general | ||
- Added better structured subdirectories for data and files (for example in the assets subdirectory or the data folders in the Table components) | ||
- Changed to absolute import paths instead of relative ones | ||
- Changed the imports from smallest length to biggest at the top of the files |