Fix heating state #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katzenbaer
reviewed
Dec 13, 2023
src/platformAccessory.ts
Outdated
Comment on lines
102
to
103
| minValue: THERMOSTAT_MIN_CURRENT_TEMP, | ||
| maxValue: THERMOSTAT_MAX_CURRENT_TEMP, |
There was a problem hiding this comment.
Was it intentional to use constants vs the user defined values?
There was a problem hiding this comment.
Yes, the current temp could be out of the range for target temperature. For example, when water heater has been idling for a while, the current temperature (outlet temperature) will be close to the main water line temperature, which is much lower than the minimal target temperature.
zimuliu
force-pushed
the
fix-heating-state
branch
6 times, most recently
from
136cb78 to
689c142
Compare
* Added the support of heating state ("Heating to" when the combustation is ON) and the current water temperature (from the outlet temperature).
* Improved the stepped target temperature calculation for controllers using imperial unit.
* Avoid adding recirulation button if the heater is not configured for it yet
zimuliu
force-pushed
the
fix-heating-state
branch
from
689c142 to
f5fea0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to address the issue reported in dustindclark#2
Example when the combustion is on
Example when the combustion is off
