make height and width properties accomodate string values in graphset

zingchart · Oct 13, 2023 · 744ffb1 · 744ffb1
1 parent f800de4
commit 744ffb1
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/package.json b/package.json
@@ -32,6 +32,7 @@
         "@definitelytyped/utils": "latest",
         "@octokit/core": "^3.5.1",
         "@octokit/rest": "^16.0.0",
+        "@types/node": "^20.8.5",
         "comment-json": "^4.2.3",
         "d3-array": "^3.0.2",
         "d3-axis": "^3.0.0",

diff --git a/types/zingchart/es6/index.d.ts b/types/zingchart/es6/index.d.ts
@@ -13069,7 +13069,7 @@ declare namespace zingchart {
         /**
          * Sets the height of the object. 10 | "20px" | 0.3 | "30%" | ...
          */
-        height?: number;
+        height?: string | number;
         /**
          * Sets the line style of the object. "solid" | "dotted" | "dashed" | "dashdot"
          */
@@ -13082,7 +13082,7 @@ declare namespace zingchart {
         /**
          * Sets the width of the object. 10 | "20px" | 0.3 | "30%" | ...
          */
-        width?: number;
+        width?: string | number;
         "3d-aspect"?: {
             /**
              * Sets the view angle when using the isometric 3D engine. Value can be between 0 and 90, with the default viewing angle being 45°. 5

diff --git a/types/zingchart/zingchart-tests.ts b/types/zingchart/zingchart-tests.ts
@@ -204,7 +204,7 @@ const chartConfig: zc.graphset[] = [
                 alpha: 0,
             },
             {
-                backgroundColor: "red",
+                backgroundColor: "green",
             },
         ],
     },
-Original file line number
+Diff line change
@@ Expand Up / @@ -204,7 +204,7 @@ const chartConfig: zc.graphset[] = [ @@
                     alpha: 0,
                 },
                 {
-                    backgroundColor: "red",
+                    backgroundColor: "green",
                 },
             ],
         },
@@ Expand Down @@