Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --version command #171

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Add --version command #171

merged 1 commit into from
Jan 28, 2025

Conversation

idky137
Copy link
Contributor

@idky137 idky137 commented Jan 28, 2025

Adds --version command to ZainoD and updates description.

@idky137 idky137 marked this pull request as ready for review January 28, 2025 13:57
@idky137 idky137 added the ZGM2 Issues that need to be resolved for the completion of the Zaino dev grant milestone 2 label Jan 28, 2025
ala-mode
ala-mode approved these changes Jan 28, 2025
View reviewed changes
Copy link

@ala-mode ala-mode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good. Confirmed working locally, with both --version itself and showing this option with --help

I noticed a capitalized command name, updated from an earlier name. If that is okay I think this should be merged.

integration-tests/Cargo.toml Show resolved Hide resolved
zainod/src/main.rs Show resolved Hide resolved
zainod/src/main.rs Show resolved Hide resolved
zancas
zancas approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@zancas zancas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.. will use the { workspace = "true" } [package] hack elsewhere!

@zancas zancas merged commit ab3183d into zingolabs:dev Jan 28, 2025
7 of 12 checks passed
@ala-mode ala-mode mentioned this pull request Jan 29, 2025
Open
@ala-mode ala-mode mentioned this pull request Feb 5, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zancas zancas zancas approved these changes

@ala-mode ala-mode ala-mode approved these changes

@AloeareV AloeareV Awaiting requested review from AloeareV

Assignees
No one assigned
Labels
ZGM2 Issues that need to be resolved for the completion of the Zaino dev grant milestone 2
Projects
Zaino - MileStone 2
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Zaino needs a --version output
3 participants
@idky137 @zancas @ala-mode