Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor bugs #1588

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

Conversation

Oscar-Pepper
Copy link
Contributor

@Oscar-Pepper Oscar-Pepper commented Dec 14, 2024

Sync should be much more finely tuned with this PR

fixes:

  1. to fix tokio polling being CPU-starved. moves located tree construction to scanning and uses spawn_blocking to keep rayon tasks in a separate thread pool to the main tokio thread
  2. fixes a bug where workers may be shutdown before scan is complete
  3. moves the point where a worker is a set to be scanning to fix a bug where workers are assigned multiple tasks
  4. fixes a mempool panic, more work to be done on mempool in following PR

@zancas
Copy link
Member

zancas commented Dec 14, 2024

I'm confused.. is there a test? How can we know whether the sync is tuned, without observations?

@Oscar-Pepper
Copy link
Contributor Author

I'm confused.. is there a test? How can we know whether the sync is tuned, without observations?

we dont have the benchmarking framework yet to show the performance improvements in the form fo a test.
i will edit the PR description to include more information about the changes / fixes

@zancas
Copy link
Member

zancas commented Dec 14, 2024

Are these bugs really "minor"? It seems like at least some are critical even if the effort to fix them is low. I am concerned that this code should be reviewed carefully, and "minor" might give the PR the wrong "flavor".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants