Bugfix: WebSocketConfig.withForwardCloseFrames does not forward Close frames #2375 #2395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webberaj81
requested review from
amitksingh1490,
jdegoes,
vigoo and
adamgfraser
as code owners
|
|
webberaj81
force-pushed
the
aw/websocket-close-fix
branch
from
6a727eb
to
b589b41
Compare
…rward Close frames fix typos, clarify descriptor add WebSocketConfig unit test for forwardCloseFrames
webberaj81
force-pushed
the
aw/websocket-close-fix
branch
from
b589b41
to
aafe6a3
Compare
jdegoes
approved these changes
Sep 24, 2023
Codecov ReportAll modified lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2395 +/- ##
==========================================
+ Coverage 64.58% 64.64% +0.05%
==========================================
Files 135 135
Lines 7153 7153
Branches 1207 1209 +2
==========================================
+ Hits 4620 4624 +4
+ Misses 2533 2529 -4
☔ View full report in Codecov by Sentry. |
* scalafmtAll
* remove unused layer
* run sFix
|
/claim #2375 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue of
WebSocketConfig.forwardCloseFrames()being inverted in that it required to be set tofalseto forward close frames to the client, andtrue(default value) to not forward close frames to the client.Also included is a unit test to verify this functionality
NOTE: This is a (necessary) functionality change that may break some existing WebSocket code.
/claim #2375