Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix broken links #2474

Closed
wants to merge 1 commit into from
Closed

fix broken links #2474

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Oct 8, 2023

No description provided.

@CLAassistant
Copy link

CLAassistant commented Oct 8, 2023

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (de31152) 64.58% compared to head (586a7da) 64.58%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2474   +/-   ##
=======================================
  Coverage   64.58%   64.58%           
=======================================
  Files         135      135           
  Lines        7153     7153           
  Branches     1207     1207           
=======================================
  Hits         4620     4620           
  Misses       2533     2533           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guizmaii
Copy link
Member

guizmaii commented Oct 8, 2023

This is most probably a zio-sbt issue and shouldn't be fixed this way but by updating zio-sbt and re-running the readme generation task

@ghost
Copy link
Author

ghost commented Oct 8, 2023

the readme generation task

wow!

Anyways, if you do this fast, the do it your way. Otherwise just merge for now, so the broken links (= sloppy impression) are fixed.

@guizmaii
Copy link
Member

guizmaii commented Oct 8, 2023

Your PR breaks CI for the reasons I mentioned

@ghost
Copy link
Author

ghost commented Oct 8, 2023

Your PR breaks CI for the reasons I mentioned

You are aware that you break the possibly most basic standard-procedure within OS: fixing a README on github.

You really should free this poor README from the CI/Generator-Tyrany.

Closing.

@ghost ghost closed this Oct 8, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants