Set default active configuration to 0 #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On module install the Zip method is set as active "1" by default. All modules should be disabled by default and enabled by the user within the Magento admin system configuration. There shouldn't be an assumption that even though the module is installed and enabled that the payment method has been configured with API keys and ready to be used as an active payment method in the checkout. Currently if the Zip module is installed on a production site, the Zip method will appear in the checkout due to this default config even without API keys configured.
|
Thank you @lytesaber . we are taking is chance to repo code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On module install the Zip method is set as active "1" by default. All modules should be disabled by default and enabled by the user within the Magento admin system configuration. There shouldn't be an assumption that even though the module is installed and enabled that the payment method has been configured with API keys and ready to be used as an active payment method in the checkout. Currently if the Zip module is installed on a production site, the Zip method will appear in the checkout due to this default config even without API keys configured.