Skip to content

Commit

Permalink
Fix issue links
Browse files Browse the repository at this point in the history
  • Loading branch information
zjwegert committed May 15, 2024
1 parent 7be8d6d commit ae4e344
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions docs/src/getting-started.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,5 +38,5 @@ More general tutorials for familiarising ones self with Gridap are available via

## Known issues
- PETSc's GAMG preconditioner breaks for split Dirichlet DoFs (e.g., x constrained while y free for a single node). There is no simple fix for this. We recommend instead using MUMPS or another preconditioner for this case.
- Currently, our implementation of automatic differentiation does not support multiplication and division of optimisation functionals. We plan to add this in a future release of `GridapTopOpt.jl` -- Issue [#38](https://github.com/zjwegert/GridapTopOpt/issues/38).
- Analytic gradient breaks in parallel for integrals of certain measures -- Issue [#46](https://github.com/zjwegert/GridapTopOpt/issues/46)
- Currently, our implementation of automatic differentiation does not support multiplication and division of optimisation functionals. We plan to add this in a future release of `GridapTopOpt.jl` -- Issue [#38](https://github.com/zjwegert/GridapTopOpt.jl/issues/38).
- Analytic gradient breaks in parallel for integrals of certain measures -- Issue [#46](https://github.com/zjwegert/GridapTopOpt.jl/issues/46)
4 changes: 2 additions & 2 deletions src/ChainRules.jl
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ function Gridap.gradient(F::IntegrandWithMeasure,uh::Vector,K::Int)
local_measures = map(local_views,F.dΩ) |> to_parray_of_arrays
contribs = map(local_measures,local_fields) do dΩ,lf
# TODO: Remove second term below, this is a fix for the problem discussed in
# https://github.com/zjwegert/GridapTopOpt/issues/46
# https://github.com/zjwegert/GridapTopOpt.jl/issues/46
_f = u -> F.F(lf[1:K-1]...,u,lf[K+1:end]...,dΩ...) #+ ∑(∫(0)dΩ[i] for i = 1:length(dΩ))
return Gridap.Fields.gradient(_f,lf[K])
end
Expand Down Expand Up @@ -585,7 +585,7 @@ struct NonlinearFEStateMap{A,B,C,D,E,F} <: AbstractFEStateMap
res = IntegrandWithMeasure(res,dΩ)
if isnothing(jac)
jacf = (u,du,v,φh) -> jacobian(res,[u,v,φh],1)
else
else
jacf = (u,du,v,φh) -> jac(u,du,v,φh,dΩ...)
end
spaces = (U,V,V_φ,U_reg)
Expand Down

0 comments on commit ae4e344

Please sign in to comment.