Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documenter and refactor #40

Merged
merged 75 commits into from
Mar 12, 2024
Merged

Documenter and refactor #40

merged 75 commits into from
Mar 12, 2024

Conversation

zjwegert
Copy link
Owner

@zjwegert zjwegert commented Feb 7, 2024

Changes

@JordiManyer, this PR is still on-going work. If you have some time, feel free to have a look at the documentation and see what you think. Feel free to contribute (again if you have some time!).

FYI to call the package we need to add the required branches to the Project.toml in docs (e.g., Gridap#master etc.). Does pinning the packages sort this problem out?

@JordiManyer
Copy link
Collaborator

JordiManyer commented Feb 7, 2024

FYI to call the package we need to add the required branches to the Project.toml in docs (e.g., Gridap#master etc.). Does pinning the packages sort this problem out?

I guess if you add the Manifest that would pin them, but I would say we don't really want to do that for a release... We should just create a new release of the packages, and then we don't have to pin them.
It should not be a problem, except for GridapSolvers... I don't think I want to publish the GMG stuff I have in there until I'm closer to publishing (which should not be long, but yeah...). I'll have to talk to Santi. Maybe we can pin that one for now and create a new release for the others.

If the whole issue is that we need those branches for documentation, we can pin the branches in the CI job that deploys it. I can probably have a look at the CI stuff once this is merged on master.

@zjwegert
Copy link
Owner Author

zjwegert commented Feb 8, 2024

I guess if you add the Manifest that would pin them, but I would say we don't really want to do that for a release... We should just create a new release of the packages, and then we don't have to pin them. It should not be a problem, except for GridapSolvers... I don't think I want to publish the GMG stuff I have in there until I'm closer to publishing (which should not be long, but yeah...). I'll have to talk to Santi. Maybe we can pin that one for now and create a new release for the others.

Sure we can create a release. Completely understand the point on GridapSolvers, let me know what you both decide.

If the whole issue is that we need those branches for documentation, we can pin the branches in the CI job that deploys it. I can probably have a look at the CI stuff once this is merged on master.

Sounds good! 👍

@zjwegert
Copy link
Owner Author

I'm going to merge this PR. Note that docs and script formatting is still in progress but this branch is massive.

@zjwegert zjwegert merged commit d8b96d2 into main Mar 12, 2024
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants