Update safe integration test #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
JohnGuilding
commented
Jun 27, 2024
•
JohnGuilding
commented
- Pulls latest Safe 7579 changes
- Updates Safe integration tests
- Updates Safe unit tests
- Runs multi-account tests in CI (default, Safe, Kernel)
- Runs simulate tests in CI (Checks against 4337 storage access rules)
JohnGuilding
force-pushed
the
feat/update-safe-integration-test
branch
from
5a334cc to
951231b
Compare
JohnGuilding
changed the title
JohnGuilding
force-pushed
the
feat/update-safe-integration-test
branch
from
f45a202 to
ca8f535
Compare
SoraSuegami
reviewed
Jul 3, 2024
script/DeploySafeRecovery.s.sol
Outdated
| address verifier = 0xEdC642bbaD91E21cCE6cd436Fdc6F040FD0fF998; | ||
| address dkimRegistry = 0xC83256CCf7B94d310e49edA05077899ca036eb78; | ||
| address emailAuthImpl = 0x1C76Aa365c17B40c7E944DcCdE4dC6e6D2A7b748; | ||
| bytes32 salt = bytes32(uint256(0)); |
There was a problem hiding this comment.
Why is the salt fixed here?
There was a problem hiding this comment.
Yeah maybe that is inconsistent with the other code. Deployed other contracts with factory which uses salts.
The code to deploy the launchpad and safe7579 contract had a salt like this, so I guess I copied it over
script/DeploySafeRecovery.s.sol
Outdated
Comment on lines
58
to
60
| address safe7579 = address(new Safe7579{ salt: salt }()); | ||
| address safe7579Launchpad = | ||
| address(new Safe7579Launchpad{ salt: salt }(entryPoint, registry)); |
There was a problem hiding this comment.
Where/when does this safe account install necessary modules?
There was a problem hiding this comment.
For this script, it is to deploy the contracts for the frontend demo. The module is installed via the frontend.
SoraSuegami
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.