Modify check for no guardians & add tests #15
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds upon changes slightly from ca7d21c and adds tests
Only calls
setupGuardians
if guardians.length, weights.length, and threshold are all 0. It felt appropriate that no guardian weights should be passed in if the guardians themselves are not known. And passing the threshold also felt like it could be redundant without knowledge of guardian count and weights. The logic added in commit ca7d21c failed when running a test with no guardians passed in because of conflicting checks insetupGuardians
. Permitting weight and threshold also be zero and adding the check inconfigureRecovery
keeps thesetupGuardian
function simple.Adds
guardianConfig.initialized
checks in existing testsAdds tests for new logic in configureRecovery.t.sol