Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/factory and script updates #17

Merged
merged 3 commits into from
Jul 2, 2024

Conversation

JohnGuilding
Copy link
Collaborator

@JohnGuilding JohnGuilding commented Jul 2, 2024

  • Factory contract takes dkim regsitry as arguments to deployment functions rather than when the factory is deployed. This is because an account/module developer may want to pass a user overidable dkim regsitry. Whereas the verifier and emailAuthImpl will be more stable addresses
  • Updates recovery calldata from changeOwner(address,address,address) to changeOwner(address). Other arguments are no longer needed as access control is implicitly handled by executor _execute helper function
  • Remove unused/commented out code from scripts
  • Renames deployment scripts to align with factory function names
  • Adds new deploy script for non-universal module

@JohnGuilding JohnGuilding merged commit cf44a21 into main Jul 2, 2024
3 checks passed
@JohnGuilding JohnGuilding deleted the feat/factory-and-script-updates branch July 2, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants