small improvements for readability and gas #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
should allow the removal of BytesLib. less code to be audited foo
zeroknots
commented
Jun 13, 2024
There was a problem hiding this comment.
was able to axe BytesLib entirely by using calldata slicing. should reduce audit LoC
There was a problem hiding this comment.
Ah yeah good shout since the calldata isn't stored in memory anymore. This is a good win
zeroknots
commented
Jun 13, 2024
| address public verifierAddr; | ||
| address public dkimAddr; | ||
| address public emailAuthImplementationAddr; | ||
| address internal immutable verifierAddr; |
There was a problem hiding this comment.
these have getter functions. so will reduce deployment bytecode size
There was a problem hiding this comment.
makes sense, posted this suggestion in zkemail/email-tx-builder#28
zeroknots
changed the title
JohnGuilding
approved these changes
Jun 13, 2024
| address public verifierAddr; | ||
| address public dkimAddr; | ||
| address public emailAuthImplementationAddr; | ||
| address internal immutable verifierAddr; |
There was a problem hiding this comment.
makes sense, posted this suggestion in zkemail/email-tx-builder#28
There was a problem hiding this comment.
Ah yeah good shout since the calldata isn't stored in memory anymore. This is a good win
JohnGuilding
merged commit 4dd50b4
into
zkemail:generic-validator-module
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found a few points for improvements during my code review. figured its easiest to take out a PR instead of making a list.
No functionality changes, but should improve on gas and readability