Prototype a new ERC7579 recovery module #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odule + Add the validation via the Verifier# verifyEoaProof() in order to check whether or not a given 'proof' and 'pubSignals' are correct
…e EmailRecoveryModule#exposed_processRecovery() (= EmailRecoveryManager#processRecovery())
…() of the EmailRecoveryModule.sol
…tructor() of the EmailRecoveryModule.sol
… from the processRecovery.t.sol to UnitBase.t.sol
…the deployModule() in the UnitBase.t.sol
…structor() and deployEmailRecoveryModule() in the EmailRecoveryFactory.sol
…t.sol + [SC]: Add the IEoaAuth.sol
…coveryModuleHarness#exposed_processRecovery() as a parameter
…#processRecovery()
…difier) to the EmailRecoveryManager#processRecovery()
…er#verifyEoaProof() in the IVerifier.sol
… the EmailRecoveryManager.sol
…related SC and ZKSync-related SC
…processRecovery() in the processRecovery.t.sol
…) with the emailRecoveryModule.exposed_processRecoveryWithEoaAuth() in the processRecoveryWithEoaAuth.t.sol
…the exposed_processRecovery() in the UniversalEmailRecoveryModuleHarness.sol
… ./test/eoa-auth/helpers
…h the StructHelper.sol
…eploymentHelper - To avoid collision between the DeploymentHelper and Base.t.sol
…n the DeploymentHelper - To avoid collision between the DeploymentHelper and Base.t.sol
….sol and DeploymentHelper.sol
…id the collision of name bettween the DeploymentHelper and Base.t.sol
…SCs to be overrided into the override()
…lement the acceptGuardianWithEoa() in the EmailRecoveryManager.sol
…cceptGuardianWithEoa() in the UniversalEmailRecoveryModuleHarness.sol
…very() and test_ProcessRecoveryWithEoaAuth_RevertWhen_GuardianStatusIsNONE() in the processRecoveryWithEoaAuth.t.sol
Prototype a new ERC7579 recovery module
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #66
My approach and its summary (and installation) is here.
My approach above would work with the Ether EOA-auth SDK (EOA TX Buider), which I implemented. It would be great if you check this module as well.
I have sent the email to [email protected] as well.
Thanks!