-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update of UserOverrideableDKIMRegistry #233
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utted codes in UserOverrideableDKIMRegistry.t.sol
wshino
reviewed
Oct 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about upgrading solc_version to match one of the ether-email-auth?
SoraSuegami
temporarily deployed
to
development
October 21, 2024 12:07 — with
GitHub Actions
Inactive
SoraSuegami
temporarily deployed
to
development
October 21, 2024 12:07 — with
GitHub Actions
Inactive
SoraSuegami
temporarily deployed
to
development
October 21, 2024 17:01 — with
GitHub Actions
Inactive
SoraSuegami
temporarily deployed
to
development
October 21, 2024 17:01 — with
GitHub Actions
Inactive
SoraSuegami
temporarily deployed
to
development
October 21, 2024 17:14 — with
GitHub Actions
Inactive
SoraSuegami
temporarily deployed
to
development
October 21, 2024 17:14 — with
GitHub Actions
Inactive
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
|
SoraSuegami
temporarily deployed
to
development
October 24, 2024 17:28 — with
GitHub Actions
Inactive
SoraSuegami
temporarily deployed
to
development
October 24, 2024 17:28 — with
GitHub Actions
Inactive
SoraSuegami
temporarily deployed
to
development
October 25, 2024 12:12 — with
GitHub Actions
Inactive
SoraSuegami
temporarily deployed
to
development
October 25, 2024 12:12 — with
GitHub Actions
Inactive
SoraSuegami
temporarily deployed
to
development
October 25, 2024 12:15 — with
GitHub Actions
Inactive
SoraSuegami
temporarily deployed
to
development
October 25, 2024 12:15 — with
GitHub Actions
Inactive
SoraSuegami
temporarily deployed
to
development
October 25, 2024 14:55 — with
GitHub Actions
Inactive
SoraSuegami
temporarily deployed
to
development
October 25, 2024 14:55 — with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current implementation of UserOverrideableDKIMRegistry only supports pessimistic key updates; i.e., each user's approval is always required to enable a new public key set by the main authorizer.
This causes liveness issues when the user loses access to their account.
However, a naive implementation for optimistic key updates, which enables a new public key set by the main authorizer without the user's approval immediately, has a safety issue when the main authority is invalid.
To make it possible to balance this tradeoff, this PR introduces a time delay until the public key set by the main authorizer is enabled without the user's approval.
Such a public key is enabled 1) after the time delay passes or 2) when the user approves the public key before the time delay passes.
Therefore, the greater the delay becomes, the closer it approaches a pessimistic update, while the opposite brings it closer to an optimistic update.
Type of Change
Please delete options that are not relevant.
Checklist: