Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

veridise audit fix: first bh tag #38

Merged
merged 2 commits into from
Feb 4, 2025
Merged

veridise audit fix: first bh tag #38

merged 2 commits into from
Feb 4, 2025

Conversation

jp4g
Copy link
Contributor

@jp4g jp4g commented Feb 3, 2025

Addresses comment to bh= may occur in other DKIM tags

This will remove the issue. However, in the case that the very *first* DKIM-signature is `bh=`, it will fail. This may deny service to valid e-mails.

The case of `bh=` being the first DKIM tag should be handled.

Adds a check for : bh= or :bh= as valid prefixes to found body hashes in dkim-signature. Includes test_body_hash_at_start as test demonstrating that this case does not deny service to email verification.

Audit stack: 2

@jp4g jp4g merged commit d130072 into main Feb 4, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant