Fix Datebox.getTimeFormat() for format consistency #3053
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
need-config.properties
rebecca0201
added
WIP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differentiate single/double 'h' and whether there is a space before/after 'a' to fix the time format inconsistency observed in
B60-ZK-1341.zul(datebox time format =ah:mm:ssbut the time format extracted by itsgetTimeFormat()used as timebox format =a hh:mm:ss). After the fix, the behavior is still different from 9.6.4 which both datebox and timebox time format =a hh:mm:ss, but the correct time format should beah:mm:ssaccording to thecomplete.jsfile.