-
-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: avoid private api on Mac App Store #804
Conversation
I'm not sure APPLE makes sense since these files are for Apple platform. |
I think we need something like this which is by default cmake_dependent_option(MZ_BUILD_FOR_APPSTORE "Build without macOS private APIs" ON "APPLE" OFF) Or |
OK. Quick question @nmoinvaz, since you need those declarations for a private project: do you want GCM on all Apple platforms (including iOS)?
|
This one. Thank you! |
Actually, I prefer to default it to [edit: arf, I inverted 0 and 1] |
/* Avoid use of private API for iOS, Apple does not allow it on App Store. Zip format doesn't need GCM. */ | ||
#if !TARGET_OS_IPHONE | ||
#ifndef MZ_TARGET_APPSTORE | ||
#define MZ_TARGET_APPSTORE 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I should have defaulted it to 1, @nmoinvaz .
Can you add a commit to flip the default value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
No description provided.