Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implicit conversion loses integer precision: 'unsigned long' to 'int32_t' #811

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

Coeur
Copy link
Contributor

@Coeur Coeur commented Oct 31, 2024

Since its very first release in 1998, OpenSSL has always returned an unsigned long:
https://github.com/openssl/openssl/blame/3edd7ed15de229230f74c79c3d71e7c9c674cf4f/crypto/err/err.c#L295

mz_crypt_openssl.c Outdated Show resolved Hide resolved
mz_crypt_openssl.c Outdated Show resolved Hide resolved
@nmoinvaz nmoinvaz added the warning fix Compiler warning silencing label Oct 31, 2024
@nmoinvaz nmoinvaz merged commit b2ad0e0 into zlib-ng:develop Oct 31, 2024
28 checks passed
@Coeur Coeur deleted the coeur/ERR_get_error branch November 1, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
warning fix Compiler warning silencing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants