Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ParamSpec #4

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove ParamSpec #4

wants to merge 1 commit into from

Conversation

Atry
Copy link
Contributor

@Atry Atry commented Oct 31, 2023 •
edited
Loading

ParamSpec is unnecessary because the number of arguments is fixed.

@Atry Atry changed the title Remove ParamSpec Remove ParamSpec Oct 31, 2023
zmievsa
zmievsa requested changes Nov 1, 2023
View reviewed changes
Copy link
Owner

@zmievsa zmievsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very true! Thank you for this PR!

Could you also update the minor version in pyproject.toml?

@Atry
Copy link
Contributor Author

Atry commented Apr 10, 2024

Version updated

zmievsa
zmievsa requested changes Apr 15, 2024
View reviewed changes
Copy link
Owner

@zmievsa zmievsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work. Added a few comments.

pyproject.toml Outdated Show resolved Hide resolved
cached_classproperty/__init__.py Outdated Show resolved Hide resolved
cached_classproperty/__init__.py Show resolved Hide resolved
@Atry Atry requested a review from zmievsa April 15, 2024 21:39
@Atry
Copy link
Contributor Author

Atry commented Apr 19, 2024

@zmievsa Any other issues?

@zmievsa
Copy link
Owner

zmievsa commented Apr 19, 2024

I will check again soon 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmievsa zmievsa Awaiting requested review from zmievsa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Atry @zmievsa