-
-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for CentOS 7 or newer to mup #949
base: master
Are you sure you want to change the base?
Conversation
This seems to work fine with CentOS 7 based VMs, like from Google Compute. The only real requirement for a CentOS host is that it can properly run Docker. The rest of mup then is unaffected by the distro (so it seems anyway). Creating a test environment in Travis CI is more difficult. I would need a container analogous to phusion/baseimage-docker but built on CentOS. The default CentOS containers do not seem to properly support running docker-in-docker. Using DIND defeats the purpose of creating a realistic test it seems. If anyone has any ideas, let me know. |
Thanks for uploading this, appreciate it. Any ideas why it wasn't merged by the team? Seems like a great patch |
Thanks for working on this @msteinmn. I would like to find a way to automate tests with centos before merging so we can ensure it doesn't break in the future. I will experiment with docker in docker and cent os. |
Any updates on this? :) |
I just went ahead and tried this on centOS 7 (exact version was CentOS Linux release 7.7.1908). Here are my steps and problems encountered:
So - couple problems encountered alongside the way here. lsb_release not in centos by default and Docker is installed check / or installation failed. Also, not sure if it is related, but I fixed the nopasswd thing AFTER I got the mup setup to go through, so it could be related to problems in mup setup phase. |
This is to use mup on CentOS VMs as many enterprises still standardize on RedHat Linux. mup has very few dependencies on the distribution. Tested on Google cloud images.