Skip to content

Commit

Permalink
Fix Background::Wait and exercise in test.
Browse files Browse the repository at this point in the history
I accidentally used `name` instead of `@name` and apparently this functionality is not called under test. So I added tests.

Before:

```
87 runs, 251 assertions, 0 failures, 0 errors, 0 skips
Coverage report generated for Integration Tests to /Users/rschneeman/Documents/projects/rundoc/coverage.
Line Coverage: 95.32% (1998 / 2096)
```

After:

```
87 runs, 251 assertions, 0 failures, 0 errors, 0 skips
Coverage report generated for Integration Tests to /Users/rschneeman/Documents/projects/rundoc/coverage.
Line Coverage: 95.66% (2006 / 2097)
```
  • Loading branch information
schneems committed Dec 16, 2024
1 parent 500fd85 commit 0deb856
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
2 changes: 1 addition & 1 deletion lib/rundoc/code_command/background/wait.rb
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ def initialize(name:, wait:, timeout: 5)
end

def background
@background ||= Rundoc::CodeCommand::Background::ProcessSpawn.find(name)
@background ||= Rundoc::CodeCommand::Background::ProcessSpawn.find(@name)
end

def to_md(env = {})
Expand Down
5 changes: 5 additions & 0 deletions test/rundoc/code_commands/background_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,11 @@ def test_stdin_with_cat_echo
output = stdin_write.call
assert_equal("hello there" + $/, output)

Rundoc::CodeCommand::Background::Wait.new(
name: "cat",
wait: "hello"
).call

Rundoc::CodeCommand::Background::Log::Clear.new(
name: "cat"
).call
Expand Down

0 comments on commit 0deb856

Please sign in to comment.