Merge pull request #97 from zombocom/schneems/fix-wait

Fix Background::Wait and exercise in test.
zombocom · Dec 16, 2024 · e2f570c · e2f570c
2 parents 500fd85 + 537392f
commit e2f570c
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,7 @@
 ## HEAD
 
+- Fix: Internal error in `background.wait` introduced in 4.1.2 (https://github.com/zombocom/rundoc/pull/97)
+
 ## 4.1.2
 
 - Fix: Background task name lookup is now lazy, this fixes a bug when using `:::>- pre.erb background.start(...)` (https://github.com/zombocom/rundoc/pull/95)

diff --git a/lib/rundoc/code_command/background/wait.rb b/lib/rundoc/code_command/background/wait.rb
@@ -8,7 +8,7 @@ def initialize(name:, wait:, timeout: 5)
     end
 
     def background
-      @background ||= Rundoc::CodeCommand::Background::ProcessSpawn.find(name)
+      @background ||= Rundoc::CodeCommand::Background::ProcessSpawn.find(@name)
     end
 
     def to_md(env = {})

diff --git a/test/rundoc/code_commands/background_test.rb b/test/rundoc/code_commands/background_test.rb
@@ -19,6 +19,11 @@ def test_stdin_with_cat_echo
         output = stdin_write.call
         assert_equal("hello there" + $/, output)
 
+        Rundoc::CodeCommand::Background::Wait.new(
+          name: "cat",
+          wait: "hello"
+        ).call
+
         Rundoc::CodeCommand::Background::Log::Clear.new(
           name: "cat"
         ).call