Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when a background task was defined it would perform work on initialization, this fails if the first task is not actually executed yet:
Gives:
Because the
background.stdin_write
call tonew()
happens at parse time, but thebackground.start
call tonew()
happens at runtime, (Becausepre.erb
is the command, and it hasn't yet created the start command and pushed it onto the stack).This change makes the lookup for background tasks lazy, so as long as the task is started by execution (runtime) of the command it will succeed.
The added test fails on main (with the error below) and passes on this branch.