Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch v2.21.0 existing network #22

Merged
merged 11 commits into from
Mar 2, 2023

Conversation

zonca
Copy link
Owner

@zonca zonca commented Mar 1, 2023

No description provided.

@zonca zonca marked this pull request as ready for review March 1, 2023 18:51
@zonca
Copy link
Owner Author

zonca commented Mar 2, 2023

@julienchastang could you and your colleagues review my changes?

the main pull request is #21, however those changes are minor and well tested in previous versions.

Here instead I made a significant change to the terraform recipe in order to use the auto_allocated_network, as suggested by Jeremy. That is necessary to have Designate assign DNS names.

The full tutorial is:
jetstream-cloud/js2docs#46

notice the extra step where I disassociate and reassociate the IP address to the master node, haven't found a better way.

@zonca
Copy link
Owner Author

zonca commented Mar 2, 2023

To simplify testing, I am merging this, but feedback is still very welcome

@zonca zonca merged commit 2bf0c6a into branch_v2.21.0 Mar 2, 2023
@zonca zonca deleted the branch_v2.21.0_existing_network branch March 2, 2023 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant