Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gui readme #455

Merged
merged 2 commits into from
Jan 25, 2024
Merged

Update gui readme #455

merged 2 commits into from
Jan 25, 2024

Conversation

hannaeko
Copy link
Member

Purpose

Update the readme to remove outdated information and make it more like other components readme.

Context

-

Changes

  • Remove some contribution text
  • Remove sécurity section because that has not be done for so long
  • Remove duplicated acknowledgment to angular cli
  • Remove release instructions
  • Reorder some sections
  • Update the build badge to use github action

How to test this PR

-

marc-vanderwal
marc-vanderwal previously approved these changes Jan 23, 2024
Copy link
Contributor

@tgreenx tgreenx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly some nits here and there

@tgreenx tgreenx added this to the v2023.2 milestone Jan 23, 2024
@tgreenx tgreenx added the A-Documentation Area: Documentation only. label Jan 23, 2024
README.md Outdated
### Documentation

There is a [public documentation]. Some more specific documents can be found in
the [docs directory](docs/).

### Contribution

This project was generate with Angular-CLI 1.6.8 and then updating.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does the sentence mean?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is unclear to me as well, I shortened it to "This project was generated with Angular-CLI 1.6.8.", even though I don't know how relevant this information is.

@hannaeko
Copy link
Member Author

I hope to have addressed all comments.

@hannaeko hannaeko merged commit a25359c into zonemaster:develop Jan 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Documentation Area: Documentation only.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants