Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup old FAQ architecture files #466

Merged
merged 2 commits into from
Jun 3, 2024
Merged

Cleanup old FAQ architecture files #466

merged 2 commits into from
Jun 3, 2024

Conversation

hannaeko
Copy link
Member

@hannaeko hannaeko commented Mar 4, 2024

Purpose

Remove unused FAQ files and scripts

Context

Following #434 some files are not used any more as the FAQ now use the common translation system.

Changes

  • Remove docs/FAQ/*
  • Remove scripts/faq.js
  • Remove unused dependency showdown (markdown to html renderer)
  • Update the translation guide

How to test this PR

Building the release (npm run release) should work.

@hannaeko hannaeko added this to the v2024.1 milestone Mar 4, 2024
@hannaeko hannaeko added the V-Patch Versioning: The change gives an update of patch in version. label Mar 4, 2024
marc-vanderwal
marc-vanderwal previously approved these changes Mar 6, 2024
View reviewed changes
mattias-p
mattias-p previously approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@mattias-p mattias-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a look around and I found src/assets/faqs/.gitkeep but no mentions of faqs being assets. Do we still need this directory or would it make sense to remove that file too?

@marc-vanderwal
Copy link
Contributor

I had a look around and I found src/assets/faqs/.gitkeep but no mentions of faqs being assets. Do we still need this directory or would it make sense to remove that file too?

The build system still generates files in the src/assets/faqs directory, so this directory is still needed.

@hannaeko hannaeko dismissed stale reviews from mattias-p and marc-vanderwal via 57ee72c March 11, 2024 09:51
@hannaeko
Copy link
Member Author

Not anymore, the script that used it has been remove with this PR, I removed the .gitkeep, thanks for noticing :)

@matsduf matsduf merged commit 9bacb43 into zonemaster:develop Jun 3, 2024
1 check passed
@tgreenx tgreenx added the S-ReleaseTested Status: The PR has been successfully tested in release testing label Jun 20, 2024
@tgreenx
Copy link
Contributor

tgreenx commented Jun 20, 2024 •
edited
Loading

v2024.1 Release testing

Following the "How to test" section, npm run release does run without issue.
Also, the FAQ remains correctly translated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattias-p mattias-p mattias-p approved these changes

@tgreenx tgreenx tgreenx approved these changes

@marc-vanderwal marc-vanderwal marc-vanderwal left review comments

@matsduf matsduf Awaiting requested review from matsduf

Assignees
No one assigned
Labels
S-ReleaseTested Status: The PR has been successfully tested in release testing V-Patch Versioning: The change gives an update of patch in version.
Projects
None yet
Milestone
v2024.1
Development

Successfully merging this pull request may close these issues.
5 participants
@hannaeko @marc-vanderwal @tgreenx @mattias-p @matsduf