Move the heavy browser dependencies to a 'browser' extra #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And make the tests that rely on them conditional. Ensure that the ZCML can be executed either way, though. Add tox and Travis environments to be sure this is exercised. Also: - Rename remaining .txt to .rst - Drop support for Python 3.3 - Badges in readme. - setup.cfg for universal wheels.
…[] should be a path or VCS url'
|
My use case is that we have a library we use with Pyramid for handling JSON input and output. It's based on mime types, and so we want to use the IContentTypeAware interface (among others) that this package provides. That library doesn't use anything from zope.browser, and we'd like to trim our dependencies, so making these things optional here seemed like a reasonable thing to do. |
tseaver
approved these changes
Sep 28, 2017
|
Thank you! A PyPI release would be nice, when convenient. |
|
Poof! You are a PyPI owner. |
|
Neat! Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And make the tests that rely on them conditional. Ensure that the ZCML can be executed either way, though. Add tox and Travis environments to be sure this is exercised.
Previously, a zope.mimetype install was very large, unconditionally pulling in zope.browser, zope.publisher and zope.formlib, which in turn pulled in zope.browserpage, zope.datetime, zope.pagetemplate, zope.tales, zope.tal, zope.browserresource, zope.traversing, transaction, and six, possibly among others. Now, those things are opt-in, leaving the default install about 10 packages smaller.
Also some gardening things: