-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/bedrock #125
Feature/bedrock #125
Conversation
Hello and thanks for this! We have an upcoming PR (#120) that introduces litellm as an engine. This should hopefully cover most models (bedrock too) with one single implementation! Let us know if you think this makes sense or if you think we should probably keep bedrock's client separated from the rest! |
hi Federico, thank you for pointing towards the LiteLLM direction. I think this PR's implementation gives an intuitive out-of-the-box experience if the user has already a |
sounds good, can you make
optional like in grok? we can merge this after that |
Thank you for the insight. I've just implemented it, please take a look. |
thanks again for this! |
New Engine with basic unit tests added to interact with AWS Bedrock. The engine needs to be initialized with a
botocore
BaseClient
for authentication/authorization purposes.It closes the issue Bedrock #105.