Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/bedrock #125

Merged
merged 6 commits into from
Oct 24, 2024
Merged

Feature/bedrock #125

merged 6 commits into from
Oct 24, 2024

Conversation

kristoftabori
Copy link
Contributor

New Engine with basic unit tests added to interact with AWS Bedrock. The engine needs to be initialized with a botocore BaseClient for authentication/authorization purposes.
It closes the issue Bedrock #105.

@kristoftabori kristoftabori mentioned this pull request Sep 28, 2024
@vinid
Copy link
Collaborator

vinid commented Sep 28, 2024

Hello and thanks for this! We have an upcoming PR (#120) that introduces litellm as an engine. This should hopefully cover most models (bedrock too) with one single implementation!

Let us know if you think this makes sense or if you think we should probably keep bedrock's client separated from the rest!

@kristoftabori
Copy link
Contributor Author

hi Federico, thank you for pointing towards the LiteLLM direction. I think this PR's implementation gives an intuitive out-of-the-box experience if the user has already a boto session running. It's a good default for people working in teams where only Bedrock-provided models are available.
I would vote for having this sperately for the time being.

@vinid
Copy link
Collaborator

vinid commented Oct 6, 2024

sounds good, can you make

langchain>=0.3.0
langchain-aws>=0.2.1

optional like in grok? we can merge this after that

@kristoftabori
Copy link
Contributor Author

sounds good, can you make

langchain>=0.3.0
langchain-aws>=0.2.1

optional like in grok? we can merge this after that

Thank you for the insight. I've just implemented it, please take a look.

@vinid vinid merged commit adadbd2 into zou-group:main Oct 24, 2024
@vinid
Copy link
Collaborator

vinid commented Oct 24, 2024

thanks again for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants