Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the query to find the two previous items wasn’t sorted in descending order, it would always return the first two items in the list (positions 1 and 2), not the two items immediately before the item we want to move up. For
nearby_query
on an item in the 10th position would return the 1st/2nd items, not the 8th/9th.The existing test didn't catch this because it was only using a 3-item list. I updated the test with 4 items, moving the 4th item up to make sure it goes between the 2nd/3rd items (instead of the 1st/2nd). Solution was to update the
nearby_query
function to accept anorder_by
direction.