Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various improvements to z/OS console panel #3445

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

JWaters02
Copy link
Member

@JWaters02 JWaters02 commented Feb 7, 2025

Proposed changes

There are 3 parts to this PR:

  1. Fixes Zowe Explorer z/OS Console Missing Icon in Activity View #3293 by adding "chevron-right" icon from the official VSCode icons pack
  2. Renames the long-winded "Zowe Explorer z/OS Console" to just "z/OS Console"
  3. Fixes that (especially in dark themes) the z/OS Console panel background colour was not in sync with the rest of the VSCode styling - this involves replacing the (deprecated) vscode webviews component with raw html/css as that library's components' stylings cannot be overriden

image

image

image

Release Notes

Milestone:

Changelog:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds or improves functionality)
  • Breaking change (a change that would cause existing functionality to not work as expected)
  • Documentation (Markdown, README updates)
  • Other (please specify above in "Proposed changes" section)

Checklist

General

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • All PR dependencies have been merged and published (if applicable)
  • A GIF or screenshot is included in the PR for visual changes
  • The pre-publish command has been executed:
    • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
    • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

  • There is coverage for the code that I have added
  • I have added new test cases and they are passing
  • I have manually tested the changes

Deployment

  • I have added developer documentation (if applicable)
  • Documentation should be added to Zowe Docs
    • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
    • Otherwise, please check with the rest of the squad about any needed documentation before merging.
  • These changes may need ported to the appropriate branches (list here):

Further comments

It's a funny coincidence that phaumer posted this suggestion of renaming the panel view after I had starting working on this PR 🙂

…ling

This meant replacing the deprecated vscode webviews component with raw html/css as that React library's components' stylings cannot be overriden

Signed-off-by: JWaters02 <[email protected]>
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.49%. Comparing base (5c645bc) to head (a816c5b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3445   +/-   ##
=======================================
  Coverage   93.49%   93.49%           
=======================================
  Files         120      120           
  Lines       12694    12694           
  Branches     2934     2930    -4     
=======================================
  Hits        11868    11868           
  Misses        825      825           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JWaters02
Copy link
Member Author

Not sure what the changelog entry for this one should be since it's a few things bundled into one.

@JillieBeanSim
Copy link
Contributor

Not sure what the changelog entry for this one should be since it's a few things bundled into one.

Hey @JWaters02 can list them separated by comma or via bullet list if you would like, we can also add @anaxceron to help fine tune the changelog entry.

JillieBeanSim
JillieBeanSim previously approved these changes Feb 13, 2025
Copy link
Contributor

@JillieBeanSim JillieBeanSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the fixes LGTM! thanks @JWaters02

JillieBeanSim
JillieBeanSim previously approved these changes Feb 14, 2025
Signed-off-by: JWaters02 <[email protected]>

chore: changelog

Signed-off-by: JWaters02 <[email protected]>
Copy link
Contributor

@JillieBeanSim JillieBeanSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding changelogs @JWaters02

@JillieBeanSim JillieBeanSim self-requested a review February 17, 2025 16:23
JillieBeanSim
JillieBeanSim previously approved these changes Feb 17, 2025
Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JWaters02 for your contribution! Left a comment about the panel icon

anaxceron
anaxceron previously approved these changes Feb 18, 2025
Co-authored-by: Timothy Johnson <[email protected]>
Signed-off-by: Joshua Waters <[email protected]>
@JWaters02 JWaters02 dismissed stale reviews from anaxceron and JillieBeanSim via 073bb0c February 20, 2025 23:23
@JWaters02 JWaters02 requested a review from t1m0thyj February 20, 2025 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Review/QA
Development

Successfully merging this pull request may close these issues.

Zowe Explorer z/OS Console Missing Icon in Activity View
4 participants