Unable to open a Sequential DS after renaming a favourited Sequential DS

[SanthoshiBoyina1]

Proposed changes

Fixes #3345

Release Notes

Milestone:

Changelog:

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• Enhancement (non-breaking change which adds or improves functionality)
• Breaking change (a change that would cause existing functionality to not work as expected)
• Documentation (Markdown, README updates)
• Other (please specify above in "Proposed changes" section)

Checklist

General

• I have read the CONTRIBUTOR GUIDANCE wiki
• All PR dependencies have been merged and published (if applicable)
• A GIF or screenshot is included in the PR for visual changes
• The pre-publish command has been executed:
  • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
  • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

• There is coverage for the code that I have added
• I have added new test cases and they are passing
• I have manually tested the changes

Deployment

• I have added developer documentation (if applicable)
• Documentation should be added to Zowe Docs
  • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
  • Otherwise, please check with the rest of the squad about any needed documentation before merging.
• These changes may need ported to the appropriate branches (list here):

Further comments

[github-actions]

📅 Suggested merge-by date: 2/24/2025

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.29%. Comparing base (1233383) to head (e14ec33).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3453      +/-   ##
==========================================
+ Coverage   93.24%   93.29%   +0.04%     
==========================================
  Files         120      120              
  Lines       12674    12692      +18     
  Branches     2800     2808       +8     
==========================================
+ Hits        11818    11841      +23     
+ Misses        855      850       -5     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[traeok]

Thanks for looking into this Santhoshi!

Is the newUri parameter a required change to fix this behavior? Extenders have to update their implementation to support the proposed function definitions for renameNode and renameFavorite, which is a breaking change as these functions are required as part of satisfying the IZoweTree interface. We should have enough information to generate a new URI based on the new label and the existing profile on the node.