Fix autocomplete url #1204
Fix autocomplete url #1204
Conversation
| @@ -56,6 +56,7 @@ export function initNewServerForm({$root, onChange}: NewServerFormProps): void { | |||
| "input.setting-input-value", | |||
| )!; | |||
|
|
|||
| <<<<<<< HEAD | |||
There was a problem hiding this comment.
Can you remove this merge conflict marker?
There was a problem hiding this comment.
I think perhaps you remove this in the second commit; in general it's worth reviewing each individual commit with a took like gitk --all for readability.
There was a problem hiding this comment.
Where has gitk been all my life!? Very useful tool, thanks for suggesting
This should be removed now
| class="setting-input-add-server" | ||
| autofocus | ||
| placeholder="your-organization.zulipchat.com" | ||
| style="width: 34ch" |
There was a problem hiding this comment.
Can you do all the styles in CSS files? It's generally harder to read code split between places.
There was a problem hiding this comment.
That makes sense, I went ahead and made this change in my most recent commit
My original thought was that by having this specific rule inline it would be contextual and less of a magic number. 34ch is the initial width of the input field which is the width of the placeholder text
Maybe I should add a comment in the stylesheet? or perhaps it's obvious
manila
force-pushed
the
Fix-AutocompleteUrl
branch
2 times, most recently
from
dca3703
to
0535542
Compare
Autocompletes when the user passes only org url, in the server url input. Fixes zulip#1012
manila
force-pushed
the
Fix-AutocompleteUrl
branch
from
0535542
to
732380f
Compare
manila
force-pushed
the
Fix-AutocompleteUrl
branch
from
732380f
to
4081195
Compare
What's this PR do?
Add auto complete domain when adding a new server, similar UX to the mobile apps when adding a new server.
Fixes #1012
Any background context you want to provide?
This is my first implementation and I anticipate that this could be farther improved. My main goal was to keep this logic in the scope of the new-server-form. I suspect this could be better implemented in a separate module
Screenshots
You have tested this PR on: