Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add emoji picker for reactions #566

Closed
wants to merge 6 commits into from

Conversation

chrisirhc
Copy link
Contributor

@chrisirhc chrisirhc commented Mar 15, 2024

TODO:

  • Tests
  • Localization
  • Add support for all emoji that aren't available by default in emoji_picker_flutter (e.g. symbols like *️⃣ , which are available in iamcal but not in emoji_picker_flutter) (Related: Use the official metadata as source  Fintasys/emoji_picker_flutter#153 )
  • Filter away emoji that were already added by current user (similar to previous ThumbsUp behavior)
  • Show 3-4 most recent emojis in the menu for reuse via final recentEmojis = await EmojiPickerUtils().getRecentEmojis();
  • Clean up commit messages to fit style guide

Demo:
Screen_recording_20240315_110944 Zulip Emoji.webm

Partially addresses #388

working version with majority of emojis

working version that handles keyboard and top edge clipping

replace add thumbs up button

add typings on emoji

fix error handling
@chrisirhc chrisirhc force-pushed the chua/add-emoji-picker branch from 0f2732d to 2470778 Compare March 15, 2024 10:27
@chrisirhc chrisirhc force-pushed the chua/add-emoji-picker branch from 5ecbf46 to cd4d8e6 Compare March 15, 2024 13:10
@gnprice
Copy link
Member

gnprice commented Oct 18, 2024

Thanks @chrisirhc for sending this! Sorry I didn't manage to look at it sooner.

There's a couple of key pieces of functionality this is missing that are part of Zulip's model of emoji:

  • the list of known emoji from Unicode varies as the server gets upgraded;
  • more critically, there are custom emoji that people have added in each Zulip realm, beyond those in Unicode.
  • (Also there's one "Zulip extra emoji", which is a sort of built-in global custom emoji: :zulip:, whose glyph is the Zulip logo.)

Those are covered in #669, which I've recently largely completed.

The emoji_picker_flutter package which this pulls in is interesting, but AFAICT from the readme it looks like it wants to handle only Unicode emoji — not custom emoji.

So I'm closing this PR because I don't think the direction it's taking is one that will meet our needs.

@gnprice gnprice closed this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants