Bug is solved, I have added the icon.png file #5909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please, move it to https://github.com/zulip/zulip-mobile/tree/main/fastlane/metadata/android/en-US/images instead, as instructed :) |
|
thanks |
|
So now is this issue resolved?? This means my PR is ready to be merged? |
|
We can hope |
|
Thanks for the guidance.. by the way!! |
|
Hello @licaon-kter I would like to know that if someone could just review my pull request and merge it, if possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the issue I have added the icon.png file in the images folder which is a sub folder in fastlane. Fix #5908