Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docker): serialport prebuilds should be ok now, so can skip rebuilding it #3440

Closed
wants to merge 1 commit into from
Closed

fix(docker): serialport prebuilds should be ok now, so can skip rebuilding it #3440

wants to merge 1 commit into from

Conversation

chrisns
Copy link
Member

@chrisns chrisns commented Nov 26, 2023

No description provided.

@chrisns chrisns changed the title serialport prebuilds should be ok now, so can skip rebuilding it fix(docker): serialport prebuilds should be ok now, so can skip rebuilding it Nov 26, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6997399048

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 21.371%
Totals Coverage Status
Change from base Build 6983832379: 0.0%
Covered Lines: 3733
Relevant Lines: 18596
💛 - Coveralls

robertsLando
robertsLando requested changes Nov 26, 2023
View reviewed changes
Copy link
Member

@robertsLando robertsLando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without that line and the changes I did related to node_modules, the install will be skipped and so the arm builds will ship with the amd64 binaries of serialport (that will not work at all on arms)

@chrisns
Copy link
Member Author

chrisns commented Nov 26, 2023

hold fire, need to get another PR fixed for serial-port

@chrisns chrisns mentioned this pull request Nov 26, 2023
Open
@chrisns
Copy link
Member Author

chrisns commented Nov 26, 2023

blocked by serialport/bindings-cpp#163 or move to non-musl (alpine) based image

@robertsLando
Copy link
Member

#3443 fixes all the problems 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertsLando robertsLando robertsLando requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrisns @coveralls @robertsLando