Skip to content

Commit

Permalink
remove _password attr
Browse files Browse the repository at this point in the history
  • Loading branch information
zxdavb committed Sep 23, 2024
1 parent af36efd commit 25593cd
Showing 1 changed file with 2 additions and 7 deletions.
9 changes: 2 additions & 7 deletions src/evohomeasync2/broker.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
HTTPStatus.UNAUTHORIZED: "Unauthorized (expired access token/unknown entity id?)",
}

SZ_USERNAME: Final = "Username" # is PascalCase, not camelCase?
SZ_USERNAME: Final = "Username" # TODO: is camelCase (and not PascalCase) OK?
SZ_PASSWORD: Final = "Password"


Expand Down Expand Up @@ -90,7 +90,7 @@ def __init__(
self._user_credentials = {
SZ_USERNAME: username,
SZ_PASSWORD: password,
} # TODO: are only ever PascalCase?
}

self.websession = websession

Expand All @@ -104,11 +104,6 @@ def username(self) -> str:
"""Return the username."""
return self._user_credentials[SZ_USERNAME]

@property # TODO: remove this whan no longer needed
def _password(self) -> str:
"""Return the username."""
return self._user_credentials[SZ_PASSWORD]

def _token_data_reset(self) -> None:
"""Reset the token data to its falsy state."""
self.access_token = ""
Expand Down

0 comments on commit 25593cd

Please sign in to comment.