Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update queryRemoval rules for August 2024 #7

Merged
merged 2 commits into from
Sep 3, 2024
Merged

update queryRemoval rules for August 2024 #7

merged 2 commits into from
Sep 3, 2024

Conversation

BurnzZ
Copy link
Contributor

@BurnzZ BurnzZ commented Sep 3, 2024

Note: Some rules have updated alphabetical ordering. It only happens when a given domain was seen lately. Otherwise, domains from old rules that weren't seen lately won't be touched at all. As time progresses, there'd be less diffs due to sorting.

Comment on lines +2451 to +2452
"pid",
"productName"
Copy link

@Gallaecio Gallaecio Sep 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First off, this is 👍.

But also, looking at the website to verify that indeed the pid query parameter has no effect, I noticed that proper URL normalization (to detect duplicates before redirects) would need a new rule type to support treating https://www.bunnings.com.au/ozito-1800w-2030psi-high-pressure-washer_p0254158 as https://www.bunnings.com.au/_p0254158 (i.e. remove everything from the last URL path part before the last _, at least when the last path ends in _p<num>). It’s not the first time I see something like that in an e-commerce website.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for raising @Gallaecio.

This normalization task seems to suit the SubpathRemovalProcessor but currently doesn't support substring removal in a given subpath. Created zytedata/duplicate-url-discarder#24 for tracking.

@BurnzZ BurnzZ merged commit c34c092 into main Sep 3, 2024
9 checks passed
@BurnzZ BurnzZ mentioned this pull request Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants