Job posting spider.

[wRAR]

No description provided.

[codecov]

Codecov Report

Attention: Patch coverage is 95.55556% with 4 lines in your changes missing coverage. Please review.

Project coverage is 97.85%. Comparing base (870e7ef) to head (9e0e658).

Files with missing lines	Patch %	Lines
zyte_spider_templates/spiders/job_posting.py	95.55%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #82      +/-   ##
==========================================
- Coverage   97.98%   97.85%   -0.14%     
==========================================
  Files          19       20       +1     
  Lines        1540     1630      +90     
==========================================
+ Hits         1509     1595      +86     
- Misses         31       35       +4     

Files with missing lines	Coverage Δ
zyte_spider_templates/spiders/job_posting.py	95.55% <95.55%> (ø)

[kmike]

We have a middleware in zyte-common-items to drop items below certain probability - what's the advantage of doing it in the spider?

[Gallaecio]

This has been implemented this way probably mirroring the e-commerce counterpart code.

[kmike]

Hmm, interesting - so, we're dropping custom attributes if the product probability is low; the middleware in zyte-common-items won't do it.

[wRAR]

Yeah, I admit I just copied the e-commerce spider and trimmed it down.

We may want to do something differently but also we may want to extract common code, and I think we need to wait until this and articles exist in the same tree.

[Gallaecio]

Looks good to me, besides the room for code-sharing with the e-commerce spider, which I am not sure how to best address and I am not sure whether or not to consider it in scope here, i.e. maybe we should handle that after we have articles and this already merged.

[wRAR]

I was asked to not merge this yet.