Add remaining Agents of S.H.I.E.L.D. cards #608
Conversation
| { | ||
| "code": "executive_board_evidence", | ||
| "name": "Executive Board Evidence", | ||
| "card_set_type_code": "evidence" |
There was a problem hiding this comment.
The set "Executive Board Evidence" is required to play "Baron Zemo" villain set (and by extension the campaign that involves "Baron Zemo")
Instead of creating a new dedicated set type code that will never be used in the future any more ,
we should better use the "special" set type code we discussed before:
#584 (comment)
"card_set_type_code": "special",
"related": "baron_zemo"
There was a problem hiding this comment.
I disagree.
- I thought I made it clear that I think that PR should get closed and that there isn't a problem to solve there.
- I don't think you can say that an Evidence card set type won't appear again in the game. We don't know what the game developers have planned. This is a new card set type being introduced by this box and I think we should call it what the game developers call it.
- I think as a whole, the relationship between cards with your proposal is backwards. Baron Zemo requires the Executive Board Evidence set to play, not the other way around. This set is also used during campaign mode for other villains. Nothing in that set requires it to only be used with Baron Zemo. I don't think we should be creating artifical links between sets when the game developers don't define that in the sets themselves.
- The infrastructure isn't set up to link sets together, nor do I believe we should. It's potentially a many to many relationship and I still haven't heard a compelling reason why we need to add any sort of complexity to support those types of strict set relationships (that the card sets themselves don't even have).
There was a problem hiding this comment.
The purpose of the 'card_set_type_code' is to allow filtering sets by type code.
It enables new features such as:
- Displaying all existing modular sets
- Displaying all existing scenarios
For example, 'Marauders' and 'Bulldozer' are not standalone scenarios, and 'Prelates' is not a regular modular set. These examples cluttered the 'card_set_type_code.'
A 'special' set type allows these unique sets to be categorized separately.
What is the purpose of creating an 'evidence' set type?
Do you plan to display all existing evidence sets?
Requires zzorba/marvelsdb#300 to support new card types
Add the remaining Agents of S.H.I.E.L.D. cards.
This includes the remaining encounter cards that weren't added on #560 before it was merged. This also adds a new Evidence set type with card types of "Evidence - Means", "Evidence - Motive", and "Evidence - Opportunity". To support those new types, I added backend changes on zzorba/marvelsdb#300.
There are 3 cards that have icons in the names. Because the name of cards always appears in anchor tags, I don't think we'll be able to add the icons properly to the card names so they are currently rendering with the placeholder text of the icon that should appear.